From 65699c036b211130c1badbe1b61a3a9de177b810 Mon Sep 17 00:00:00 2001
From: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Date: Sun, 27 Feb 2022 19:15:48 -0500
Subject: [PATCH] Rewrite blorg tests without external md5sum

It's a little bit longer, but avoids the need for external tools like
find and md5sum.
---
 blorg/config_test.go | 77 ++++++++++++++++++++++++++++++++++++--------
 1 file changed, 64 insertions(+), 13 deletions(-)

diff --git a/blorg/config_test.go b/blorg/config_test.go
index f75e10b..6c99d4a 100644
--- a/blorg/config_test.go
+++ b/blorg/config_test.go
@@ -1,36 +1,87 @@
 package blorg
 
 import (
-	"fmt"
+	"bufio"
+	"crypto/md5"
+	"encoding/hex"
+	"io/fs"
 	"io/ioutil"
-	"os/exec"
+	"os"
+	"path/filepath"
 	"strings"
 	"testing"
 )
 
 func TestBlorg(t *testing.T) {
+	// Re-generate this file with `find testdata/public -type f | sort -u | xargs md5sum > testdata/public.md5`
+	hashFile, err := os.Open("testdata/public.md5")
+	if err != nil {
+		t.Errorf("Could not open hash file: %s", err)
+		return
+	}
+	defer hashFile.Close()
+	scanner := bufio.NewScanner(hashFile)
+	committedHashes := make(map[string]string)
+	for scanner.Scan() {
+		parts := strings.Fields(scanner.Text())
+		if len(parts) != 2 {
+			t.Errorf("Could not split hash entry line in 2: len(parts)=%d", len(parts))
+			return
+		}
+		hash := parts[0]
+		fileName := parts[1]
+		committedHashes[fileName] = hash
+	}
+	if err := scanner.Err(); err != nil {
+		t.Errorf("Failed to read hash file: %s", err)
+		return
+	}
+
 	config, err := ReadConfig("testdata/blorg.org")
 	if err != nil {
 		t.Errorf("Could not read config: %s", err)
 		return
 	}
-	committedHashBs, err := ioutil.ReadFile("testdata/public.md5")
-	if err != nil {
-		t.Errorf("Could not read hash bytes: %s", err)
-		return
-	}
 	if err := config.Render(); err != nil {
 		t.Errorf("Could not render: %s", err)
 		return
 	}
-	renderedHashBs, err := exec.Command("bash", "-c", fmt.Sprintf("find %s -type f | sort -u | xargs md5sum", config.PublicDir)).Output()
+
+	renderedFileHashes := make(map[string]string)
+	err = filepath.WalkDir(config.PublicDir, func(path string, d fs.DirEntry, err error) error {
+		if err != nil {
+			return err
+		}
+		if d.IsDir() {
+			return nil
+		}
+		data, err := ioutil.ReadFile(path)
+		if err != nil {
+			return err
+		}
+		hash := md5.Sum(data)
+		renderedFileHashes[path] = hex.EncodeToString(hash[:])
+		return nil
+	})
 	if err != nil {
-		t.Errorf("Could not hash PublicDir: %s", err)
+		t.Errorf("Could not determine hashes of rendered files: %s", err)
 		return
 	}
-	rendered, committed := strings.TrimSpace(string(renderedHashBs)), strings.TrimSpace(string(committedHashBs))
-	if rendered != committed {
-		t.Errorf("PublicDir hashes do not match: '%s' -> '%s'", committed, rendered)
-		return
+
+	for file, rendered := range renderedFileHashes {
+		if _, ok := committedHashes[file]; !ok {
+			t.Errorf("New file %s does not have a committed hash", file)
+			continue
+		}
+		committed := committedHashes[file]
+		committedHashes[file] = "" // To check if there are missing files later.
+		if rendered != committed {
+			t.Errorf("PublicDir hashes do not match for %s: '%s' -> '%s'", file, committed, rendered)
+		}
+	}
+	for file, committed := range committedHashes {
+		if committed != "" {
+			t.Errorf("Missing file %s has a committed hash, but was not rendered", file)
+		}
 	}
 }