OrgWiki/go-org-orgwiki
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #9 from leenzhu/master

Browse source 
WriteDescriptiveListItem() missing closing tags for dt and dd
This commit is contained in:
Niklas Fasching 2019-08-26 14:34:26 +02:00 • committed by GitHub
commit e6c8cdbd9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

3
org/html_writer.go
View file

@ -335,9 +335,10 @@ func (w *HTMLWriter) WriteDescriptiveListItem(di DescriptiveListItem) {
} else { } else {
w.WriteString("?") w.WriteString("?")
} }
w.WriteString("</dt>\n")
w.WriteString("<dd>\n") w.WriteString("<dd>\n")
WriteNodes(w, di.Details...) WriteNodes(w, di.Details...)
w.WriteString("<dd>\n") w.WriteString("</dd>\n")
} }
func (w *HTMLWriter) WriteParagraph(p Paragraph) { func (w *HTMLWriter) WriteParagraph(p Paragraph) {

40
org/testdata/lists.html vendored
View file

@ -109,26 +109,30 @@ descriptive lists
</p> </p>
<dl> <dl>
<dt class="unchecked"> <dt class="unchecked">
term<dd> term</dt>
<dd>
<p> <p>
details details
continued details continued details
</p> </p>
<dd> </dd>
<dt class="unchecked"> <dt class="unchecked">
?<dd> ?</dt>
<dd>
<p> <p>
details without a term details without a term
</p> </p>
<dd> </dd>
<dt class="checked"> <dt class="checked">
term<dd> term</dt>
<dd>
<p> <p>
details on a new line details on a new line
</p> </p>
<dd> </dd>
<dt> <dt>
term<dd> term</dt>
<dd>
<p> <p>
details on a new line (with an empty line in between) details on a new line (with an empty line in between)
<strong>continued</strong> <strong>continued</strong>
@ -140,7 +144,7 @@ echo &#34;Hello World!&#34;
</pre> </pre>
</div> </div>
</div> </div>
<dd> </dd>
</dl> </dl>
<p> <p>
some list termination tests some list termination tests
@ -207,31 +211,35 @@ ordered 2
</ol> </ol>
<dl> <dl>
<dt> <dt>
unordered descriptive<dd> unordered descriptive</dt>
<dd>
<p> <p>
1 1
</p> </p>
<dd> </dd>
<dt> <dt>
unordered descriptive<dd> unordered descriptive</dt>
<dd>
<p> <p>
2 2
</p> </p>
<dd> </dd>
</dl> </dl>
<dl> <dl>
<dt> <dt>
ordered descriptive<dd> ordered descriptive</dt>
<dd>
<p> <p>
1 1
</p> </p>
<dd> </dd>
<dt> <dt>
ordered descriptive<dd> ordered descriptive</dt>
<dd>
<p> <p>
2 2
</p> </p>
<dd> </dd>
</dl> </dl>
<ul> <ul>
<li> <li>