From 0c2001e611d18e2e880f061dbb11e8030763c8e9 Mon Sep 17 00:00:00 2001 From: Sean Breckenridge Date: Mon, 3 Jun 2024 17:19:59 -0700 Subject: [PATCH] dont lowercase null when checking lowers the chance that if the value is actually "NULL" or 'Null' or something, it isn't misidentified --- my/smscalls.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/my/smscalls.py b/my/smscalls.py index 2262f65..4231801 100644 --- a/my/smscalls.py +++ b/my/smscalls.py @@ -209,7 +209,9 @@ def mms() -> Iterator[Res[MMS]]: def _resolve_null_str(value: Optional[str]) -> Optional[str]: if value is None: return None - if value.lower() == 'null': + # hmm.. theres some risk of the text actually being 'null', but theres + # no way to distinguish that from XML values + if value == 'null': return None return value