fz0x1/HPI
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

doctor: better quick option propogation for stats (#239)

Browse source 
doctor: better quick option propogation for stats

* use contextmanager for quick stats instead of editing global state
  directly
* send quick to lots of stat related functions, so they
could possibly be used without doctor, if someone wanted to
* if a stats function has a 'quick' kwarg, send the value
there as well
* add an option to sort locations in my.time.tz.via_location
This commit is contained in:
seanbreckenridge 2022-05-01 16:13:05 -07:00 • committed by GitHub
parent f43eedd52a
commit 0ce44bf0d1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 60 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

29
my/core/common.py
View file

@ -2,6 +2,7 @@ from glob import glob as do_glob
from pathlib import Path
from datetime import datetime
import functools
from contextlib import contextmanager
import types
from typing import Union, Callable, Dict, Iterable, TypeVar, Sequence, List, Optional, Any, cast, Tuple, TYPE_CHECKING
import warnings
@ -425,16 +426,32 @@ def warn_if_empty(f):
return wrapped # type: ignore
# hacky hook to speed up for 'hpi doctor'
# todo think about something better
# global state that turns on/off quick stats
# can use the 'quick_stats' contextmanager
# to enable/disable this in cli so that module 'stats'
# functions don't have to implement custom 'quick' logic
QUICK_STATS = False
# incase user wants to use the stats functions/quick option
# elsewhere -- can use this decorator instead of editing
# the global state directly
@contextmanager
def quick_stats():
global QUICK_STATS
prev = QUICK_STATS
try:
QUICK_STATS = True
yield
finally:
QUICK_STATS = prev
C = TypeVar('C')
Stats = Dict[str, Any]
StatsFun = Callable[[], Stats]
# todo not sure about return type...
def stat(func: Union[Callable[[], Iterable[C]], Iterable[C]]) -> Stats:
def stat(func: Union[Callable[[], Iterable[C]], Iterable[C]], quick: bool=False) -> Stats:
if callable(func):
fr = func()
fname = func.__name__
@ -451,13 +468,13 @@ def stat(func: Union[Callable[[], Iterable[C]], Iterable[C]]) -> Stats:
rows=len(df),
)
else:
res = _stat_iterable(fr)
res = _stat_iterable(fr, quick=quick)
return {
fname: res,
}
def _stat_iterable(it: Iterable[C]) -> Any:
def _stat_iterable(it: Iterable[C], quick: bool=False) -> Any:
from more_itertools import ilen, take, first
# todo not sure if there is something in more_itertools to compute this?
@ -476,7 +493,7 @@ def _stat_iterable(it: Iterable[C]) -> Any:
eit = funcit()
count: Any
if QUICK_STATS:
if quick or QUICK_STATS:
initial = take(100, eit)
count = len(initial)
if first(eit, None) is not None: # todo can actually be none...