fz0x1/HPI
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

core/sqlite: extract immutable connection helper

Browse source 
use in bluemaestro/zotero modules
This commit is contained in:
Dima Gerasimov 2021-04-04 22:21:41 +01:00
parent 349ab78fca
commit 68329361ad
4 changed files with 41 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
my/core/dataset.py
View file

@ -1,12 +1,14 @@
from pathlib import Path
from .common import assert_subpackage; assert_subpackage(__name__)
from .common import PathIsh
from .sqlite import sqlite_connect_immutable
# TODO wonder if also need to open without WAL.. test this on read-only directory/db file
def connect_readonly(db: Path):
def connect_readonly(db: PathIsh):
import dataset # type: ignore
# see https://github.com/pudo/dataset/issues/136#issuecomment-128693122
# todo not sure if mode=ro has any benefit, but it doesn't work on read-only filesystems
# maybe it should autodetect readonly filesystems and apply this? not sure
import sqlite3
# https://www.sqlite.org/draft/uri.html#uriimmutable
creator = lambda: sqlite3.connect(f'file:{db}?immutable=1', uri=True)
creator = lambda: sqlite_connect_immutable(db)
return dataset.connect('sqlite:///', engine_kwargs={'creator': creator})