core/source: use import error (#211)

core/source: use import error

uses the more broad ImportError
instead of ModuleNotFoundError

reasoning being if some submodule
(the one I'm configuring currently is
my.twitter.twint) doesn't have additional
imports from another parser/DAL, but it
still has a config block, the user would
have to create a stub-config block in their
config to use the all.py file
This commit is contained in:
seanbreckenridge 2022-02-10 00:57:52 -08:00 committed by GitHub
parent bea2c6a201
commit 7bf316eb9a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 12 deletions

View file

@ -223,6 +223,7 @@ def modules_check(*, verbose: bool, list_all: bool, quick: bool, for_modules: Li
from .util import get_stats, HPIModule
from .stats import guess_stats
from .error import warn_my_config_import_error
mods: Iterable[HPIModule]
if len(for_modules) == 0:
@ -243,14 +244,10 @@ def modules_check(*, verbose: bool, list_all: bool, quick: bool, for_modules: Li
except Exception as e:
# todo more specific command?
error(f'{click.style("FAIL", fg="red")}: {m:<50} loading failed{vw}')
if isinstance(e, ImportError):
em = re.match(r"cannot import name '(\w+)' from 'my.config'", str(e))
if em is not None:
section_name = em.group(1)
eprint(click.style(f"""\
You're likely missing '{section_name}' section from your config.
See https://github.com/karlicoss/HPI/blob/master/doc/SETUP.org#private-configuration-myconfig\
""", fg='yellow'))
# check that this is an import error in particular, not because
# of a ModuleNotFoundError because some dependency wasnt installed
if type(e) == ImportError:
warn_my_config_import_error(e)
if verbose:
tb(e)
continue