core.common: move assert_subpackage to my.core.internal

my/core/cachew.py

@@ -1,4 +1,4 @@
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 from contextlib import contextmanager
 import logging

my/core/common.py

@@ -173,12 +173,6 @@ def asdict(thing: Any) -> Json:
     raise TypeError(f'Could not convert object {thing} to dict')
 
 
-def assert_subpackage(name: str) -> None:
-    # can lead to some unexpected issues if you 'import cachew' which being in my/core directory.. so let's protect against it
-    # NOTE: if we use overlay, name can be smth like my.origg.my.core.cachew ...
-    assert name == '__main__' or 'my.core' in name, f'Expected module __name__ ({name}) to be __main__ or start with my.core'
-
-
 # TODO deprecate and suggest to use one from my.core directly? not sure
 from .utils.itertools import unique_everseen
 

my/core/freezer.py

@@ -1,4 +1,4 @@
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 import dataclasses as dcl
 import inspect

my/core/influxdb.py

@@ -1,7 +1,8 @@
 '''
 TODO doesn't really belong to 'core' morally, but can think of moving out later
 '''
-from .common import assert_subpackage; assert_subpackage(__name__)
+
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 from typing import Iterable, Any, Optional, Dict
 

my/core/internal.py

@@ -0,0 +1,9 @@
+"""
+Utils specific to hpi core, shouldn't really be used by HPI modules
+"""
+
+
+def assert_subpackage(name: str) -> None:
+    # can lead to some unexpected issues if you 'import cachew' which being in my/core directory.. so let's protect against it
+    # NOTE: if we use overlay, name can be smth like my.origg.my.core.cachew ...
+    assert name == '__main__' or 'my.core' in name, f'Expected module __name__ ({name}) to be __main__ or start with my.core'

my/core/kompress.py

@@ -1,4 +1,4 @@
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 from . import warnings
 
 # do this later -- for now need to transition modules to avoid using kompress directly (e.g. ZipPath)

my/core/mime.py

@@ -2,7 +2,7 @@
 Utils for mime/filetype handling
 """
 
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 import functools
 

my/core/pytest.py

@@ -2,7 +2,7 @@
 Helpers to prevent depending on pytest in runtime
 """
 
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 import sys
 import typing

my/core/sqlite.py

@@ -1,4 +1,4 @@
-from .common import assert_subpackage; assert_subpackage(__name__)
+from .internal import assert_subpackage; assert_subpackage(__name__)
 
 
 from contextlib import contextmanager