fz0x1/HPI
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ruff: enable PERF checks set

Browse source
This commit is contained in:
Dima Gerasimov 2024-08-28 02:16:12 +01:00 • committed by karlicoss
parent 985c0f94e6
commit bd1e5d2f11
4 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
my/core/query.py
View file

@ -114,7 +114,7 @@ def attribute_func(obj: T, where: Where, default: Optional[U] = None) -> Optiona
if where(v): if where(v):
return lambda o: o.get(k, default) # type: ignore[union-attr] return lambda o: o.get(k, default) # type: ignore[union-attr]
elif dataclasses.is_dataclass(obj): elif dataclasses.is_dataclass(obj):
for (field_name, _annotation) in obj.__annotations__.items(): for field_name in obj.__annotations__.keys():
if where(getattr(obj, field_name)): if where(getattr(obj, field_name)):
return lambda o: getattr(o, field_name, default) return lambda o: getattr(o, field_name, default)
elif is_namedtuple(obj): elif is_namedtuple(obj):

2
my/core/stats.py
View file

@ -440,7 +440,7 @@ def _guess_datetime(x: Any) -> Optional[datetime]:
d = asdict(x) d = asdict(x)
except: # noqa: E722 bare except except: # noqa: E722 bare except
return None return None
for _k, v in d.items(): for v in d.values():
if isinstance(v, datetime): if isinstance(v, datetime):
return v return v
return None return None

2
my/polar.py
View file

@ -199,7 +199,7 @@ class Loader:
def load_items(self, metas: Json) -> Iterable[Highlight]: def load_items(self, metas: Json) -> Iterable[Highlight]:
for _p, meta in metas.items(): for _p, meta in metas.items(): # noqa: PERF102
with wrap(meta, throw=not config.defensive) as meta: with wrap(meta, throw=not config.defensive) as meta:
yield from self.load_item(meta) yield from self.load_item(meta)

9
ruff.toml
View file

@ -10,6 +10,7 @@ lint.extend-select = [
"PLR", # 'refactor' rules "PLR", # 'refactor' rules
"B", # 'bugbear' set -- various possible bugs "B", # 'bugbear' set -- various possible bugs
"PERF", # various potential performance speedups
# "FA", # TODO enable later after we make sure cachew works? # "FA", # TODO enable later after we make sure cachew works?
# "ARG", # TODO useful, but results in some false positives in pytest fixtures... maybe later # "ARG", # TODO useful, but results in some false positives in pytest fixtures... maybe later
# "S", # bandit (security checks) -- tends to be not very useful, lots of nitpicks # "S", # bandit (security checks) -- tends to be not very useful, lots of nitpicks
@ -65,4 +66,12 @@ lint.ignore = [
"B010", # same as above, but setattr "B010", # same as above, but setattr
"B017", # pytest.raises(Exception) "B017", # pytest.raises(Exception)
"B023", # seems to result in false positives? "B023", # seems to result in false positives?
# a bit too annoying, offers to convert for loops to list comprehension
# , which may heart readability
"PERF401",
# suggests no using exception in for loops
# we do use this technique a lot, plus in 3.11 happy path exception handling is "zero-cost"
"PERF203",
] ]