fz0x1/Picocrypt
1
0
Fork 0
mirror of https://github.com/Picocrypt/Picocrypt.git synced 2025-05-12 13:48:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panic if crypto/rand.Read errors

Browse source 
Otherwise it would potentially allow zeroed values to be used in the volume which is not good. But this is highly unlikely so not a huge worry.
This commit is contained in:
Evan Su 2024-09-03 00:09:03 -04:00
parent c0f9e582bb
commit fce558b8be
1 changed files with 21 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/Picocrypt.go
View file

@ -448,7 +448,9 @@ func draw() {
fout, _ := os.Create(file)
data := make([]byte, 32)
rand.Read(data)
if _, err := rand.Read(data); err != nil {
panic(err)
}
_, err = fout.Write(data)
fout.Close()
if err != nil {
@ -1353,10 +1355,18 @@ func work() {
_, errs[3] = fout.Write(rsEncode(rs5, flags))
// Fill values with Go's CSPRNG
rand.Read(salt)
rand.Read(hkdfSalt)
rand.Read(serpentIV)
rand.Read(nonce)
if _, err := rand.Read(salt); err != nil {
panic(err)
}
if _, err := rand.Read(hkdfSalt); err != nil {
panic(err)
}
if _, err := rand.Read(serpentIV); err != nil {
panic(err)
}
if _, err := rand.Read(nonce); err != nil {
panic(err)
}
// Encode values with Reed-Solomon and write to file
_, errs[4] = fout.Write(rsEncode(rs16, salt))
@ -1897,8 +1907,12 @@ func work() {
// Use a random Argon2 salt and XChaCha20 nonce
salt := make([]byte, 16)
nonce := make([]byte, 24)
rand.Read(salt)
rand.Read(nonce)
if _, err := rand.Read(salt); err != nil {
panic(err)
}
if _, err := rand.Read(nonce); err != nil {
panic(err)
}
fout.Write(salt)
fout.Write(nonce)