From f9619a8e1cfc6d012ca2be7d038511626e743a62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= Date: Sat, 18 Aug 2018 11:43:38 +0200 Subject: [PATCH] Fix ResourceWarning: unclosed file, in tests --- tests/test_exifHeader.py | 9 ++++----- tests/test_lsb.py | 11 ++++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/test_exifHeader.py b/tests/test_exifHeader.py index f26083b..cda0e13 100644 --- a/tests/test_exifHeader.py +++ b/tests/test_exifHeader.py @@ -86,12 +86,11 @@ class TestEXIFHeader(unittest.TestCase): def test_with_bytes(self): outputBytes = io.BytesIO() message = b"Secret" - exifHeader.hide(open("./tests/sample-files/20160505T130442.jpg", 'rb'), - outputBytes, - secret_message=message) + with open("./tests/sample-files/20160505T130442.jpg", 'rb') as f: + exifHeader.hide(f, outputBytes, secret_message=message) - clear_message = exifHeader.reveal(outputBytes) - self.assertEqual(message, clear_message) + clear_message = exifHeader.reveal(outputBytes) + self.assertEqual(message, clear_message) def tearDown(self): try: diff --git a/tests/test_lsb.py b/tests/test_lsb.py index 6c2fde9..0030fea 100644 --- a/tests/test_lsb.py +++ b/tests/test_lsb.py @@ -134,13 +134,14 @@ class TestLSB(unittest.TestCase): for message in messages_to_hide: message = "Hello World" outputBytes = io.BytesIO() - bytes_image = lsb.hide(open("./tests/sample-files/20160505T130442.jpg", 'rb'), message) - bytes_image.save(outputBytes, "PNG") - outputBytes.seek(0) + with open("./tests/sample-files/20160505T130442.jpg", 'rb') as f: + bytes_image = lsb.hide(f, message) + bytes_image.save(outputBytes, "PNG") + outputBytes.seek(0) - clear_message = lsb.reveal(outputBytes) + clear_message = lsb.reveal(outputBytes) - self.assertEqual(message, clear_message) + self.assertEqual(message, clear_message) def tearDown(self): try: