fz0x1/jrnl
1
0
Fork 0
mirror of https://github.com/jrnl-org/jrnl.git synced 2025-05-20 13:08:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix missing parentheses and remove skip_win on test that is passing in Windows now

Browse source
This commit is contained in:
Micah Jerome Ellison 2021-01-16 13:30:36 -08:00
parent 3c4dc79e8a
commit 00e25f30fd
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
features/format.feature
View file

@ -396,7 +396,6 @@ Feature: Custom formats
| basic_folder | | basic_folder |
| basic_dayone | | basic_dayone |
@skip_win
Scenario Outline: Export to yaml Scenario Outline: Export to yaml
Given we use the config "<config>.yaml" Given we use the config "<config>.yaml"
And we use the password "test" if prompted And we use the password "test" if prompted

2
jrnl/os_compat.py
View file

@ -15,4 +15,4 @@ def on_posix():
def split_args(args): def split_args(args):
"""Split arguments and add escape characters as appropriate for the OS""" """Split arguments and add escape characters as appropriate for the OS"""
return shlex.split(args, posix=on_posix) return shlex.split(args, posix=on_posix())

4
tests/test_os_compat.py
View file

@ -67,7 +67,7 @@ def test_on_posix(systems):
) )
def test_split_args_on_windows(args): def test_split_args_on_windows(args):
input_arguments, expected_split_args = args[0], args[1] input_arguments, expected_split_args = args[0], args[1]
with mock.patch("jrnl.os_compat.on_windows", True): with mock.patch("jrnl.os_compat.on_windows", lambda: True):
assert split_args(input_arguments) == expected_split_args assert split_args(input_arguments) == expected_split_args
@ -83,5 +83,5 @@ def test_split_args_on_windows(args):
) )
def test_split_args_on_not_windows(args): def test_split_args_on_not_windows(args):
input_arguments, expected_split_args = args[0], args[1] input_arguments, expected_split_args = args[0], args[1]
with mock.patch("jrnl.os_compat.on_windows", True): with mock.patch("jrnl.os_compat.on_windows", lambda: True):
assert split_args(input_arguments) == expected_split_args assert split_args(input_arguments) == expected_split_args