From 36121007b1a8b476571a51dddbbb49fdda3c6131 Mon Sep 17 00:00:00 2001 From: Kevin Date: Sat, 4 Jun 2022 13:09:07 -0700 Subject: [PATCH] -not search parameter doesn't open editor (#1490) --- jrnl/jrnl.py | 1 + tests/bdd/features/search.feature | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/jrnl/jrnl.py b/jrnl/jrnl.py index 1c536a37..3eecdfd4 100644 --- a/jrnl/jrnl.py +++ b/jrnl/jrnl.py @@ -81,6 +81,7 @@ def _is_write_mode(args, config, **kwargs): args.delete, args.edit, args.change_time, + args.excluded, args.export, args.end_date, args.today_in_history, diff --git a/tests/bdd/features/search.feature b/tests/bdd/features/search.feature index 44e8dc6d..60b4fefb 100644 --- a/tests/bdd/features/search.feature +++ b/tests/bdd/features/search.feature @@ -183,6 +183,19 @@ Feature: Searching in a journal | basic_folder.yaml | | basic_dayone.yaml | + Scenario Outline: Using -not should exclude all entries with that tag + # https://github.com/jrnl-org/jrnl/issues/1472 + Given we use the config "" + When we run "jrnl -not @tagtwo" + Then the output should not contain "@tagtwo" + And the editor should not have been called + + Examples: configs + | config_file | + | basic_onefile.yaml | + | basic_folder.yaml | + | basic_dayone.yaml | + Scenario: DayOne tag searching should work with tags containing a mixture of upper and lower case. # https://github.com/jrnl-org/jrnl/issues/354 Given we use the config "dayone.yaml"