fz0x1/jrnl
1
0
Fork 0
mirror of https://github.com/jrnl-org/jrnl.git synced 2025-05-10 16:48:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Create directory if it doesn't exist (#963)

Browse source 
* create dir if it doesn't exist
* switch order of print and creation
* makedirs instead of mkdir and stderr printing
* add test
* black reformatting
This commit is contained in:
Eshan 2020-06-06 15:46:06 -04:00 • committed by GitHub
parent ca73c74a8e
commit 74724b2185
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
features/core.feature
View file

@ -113,3 +113,9 @@ Feature: Basic reading and writing to a journal
2013-06-10 15:40 Life is good. 2013-06-10 15:40 Life is good.
""" """
And we should get no error And we should get no error
Scenario: Journal directory does not exist
Given we use the config "missing_directory.yaml"
When we run "jrnl Life is good"
and we run "jrnl -n 1"
Then the output should contain "Life is good"

5
jrnl/EncryptedJournal.py
View file

@ -40,8 +40,11 @@ class EncryptedJournal(Journal):
"""Opens the journal file defined in the config and parses it into a list of Entries. """Opens the journal file defined in the config and parses it into a list of Entries.
Entries have the form (date, title, body).""" Entries have the form (date, title, body)."""
filename = filename or self.config["journal"] filename = filename or self.config["journal"]
dirname = os.path.dirname(filename)
if not os.path.exists(filename): if not os.path.exists(filename):
if not os.path.isdir(dirname):
os.makedirs(dirname)
print(f"[Directory {dirname} created]", file=sys.stderr)
self.create_file(filename) self.create_file(filename)
self.password = util.create_password(self.name) self.password = util.create_password(self.name)
print( print(

5
jrnl/Journal.py
View file

@ -74,8 +74,11 @@ class Journal:
"""Opens the journal file defined in the config and parses it into a list of Entries. """Opens the journal file defined in the config and parses it into a list of Entries.
Entries have the form (date, title, body).""" Entries have the form (date, title, body)."""
filename = filename or self.config["journal"] filename = filename or self.config["journal"]
dirname = os.path.dirname(filename)
if not os.path.exists(filename): if not os.path.exists(filename):
if not os.path.isdir(dirname):
os.makedirs(dirname)
print(f"[Directory {dirname} created]", file=sys.stderr)
self.create_file(filename) self.create_file(filename)
print(f"[Journal '{self.name}' created at {filename}]", file=sys.stderr) print(f"[Journal '{self.name}' created at {filename}]", file=sys.stderr)