fz0x1/jrnl
1
0
Fork 0
mirror of https://github.com/jrnl-org/jrnl.git synced 2025-06-28 13:36:14 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix OS compatibility issues for editors with spaces, slashes, and quotes (#1153)

Browse source 
* Fix inverted POSIX check, refactor os_compat, and add tests for it
* Fix missing parentheses and remove skip_win on test that is passing in Windows now
* Fix expected quotes in quoted args
* Make  output clearer on failing test
* Bringing skip_win back to test whose failure is a bit more complicated than expected
This commit is contained in:
Micah Jerome Ellison 2021-01-16 15:19:11 -08:00 • committed by GitHub
parent b6b6e7750e
commit 9e6cd8820f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 121 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
features/environment.py
View file

@ -42,7 +42,7 @@ def before_feature(context, feature):
feature.skip()
return
if "skip_win" in feature.tags and on_windows:
if "skip_win" in feature.tags and on_windows():
feature.skip("Skipping on Windows")
return
@ -69,7 +69,7 @@ def before_scenario(context, scenario):
scenario.skip()
return
if "skip_win" in scenario.effective_tags and on_windows:
if "skip_win" in scenario.effective_tags and on_windows():
scenario.skip("Skipping on Windows")
return