From abbb2c502f2a5546fb8f1f8ee4a0812cc2652c3c Mon Sep 17 00:00:00 2001
From: Suhas <sugas182@gmail.com>
Date: Wed, 27 Jan 2021 18:09:10 -0500
Subject: [PATCH] organize deserialization unittests

---
 tests/test_parse_args.py | 44 +++++++++++++++++++++++++---------------
 1 file changed, 28 insertions(+), 16 deletions(-)

diff --git a/tests/test_parse_args.py b/tests/test_parse_args.py
index 5b02fbfc..8e314aad 100644
--- a/tests/test_parse_args.py
+++ b/tests/test_parse_args.py
@@ -4,7 +4,7 @@ import shlex
 import pytest
 
 from jrnl.args import parse_args
-
+from jrnl.args import deserialize_config_args
 
 def cli_as_dict(str):
     cli = shlex.split(str)
@@ -206,24 +206,36 @@ def test_version_alone():
 
     assert cli_as_dict("--version") == expected_args(preconfig_cmd=preconfig_version)
 
+class TestDeserialization:
+    @pytest.mark.parametrize(
+        "input_str",
+        [
+            'editor:"nano", colors.title:blue, default:"/tmp/egg.txt"',
+            'editor:"vi -c startinsert", colors.title:blue, default:"/tmp/egg.txt"',
+            'editor:"nano", colors.title:blue, default:"/tmp/eg\ g.txt"',
+        ],
+    )
+    def test_deserialize_multiword_strings(self,input_str):
+        
 
-@pytest.mark.parametrize(
-    "input_str",
-    [
-        'editor:"nano", colors.title:blue, default:"/tmp/egg.txt"',
-        'editor:"vi -c startinsert", colors.title:blue, default:"/tmp/egg.txt"',
-        'editor:"nano", colors.title:blue, default:"/tmp/eg\ g.txt"',
-    ],
-)
-def test_deserialize_config_args(input_str):
-    from jrnl.args import deserialize_config_args
+        runtime_config = deserialize_config_args(input_str)
+        assert runtime_config.__class__ == dict
+        assert "editor" in runtime_config.keys()
+        assert "colors.title" in runtime_config.keys()
+        assert "default" in runtime_config.keys()
 
-    runtime_config = deserialize_config_args(input_str)
-    assert runtime_config.__class__ == dict
-    assert "editor" in runtime_config.keys()
-    assert "colors.title" in runtime_config.keys()
-    assert "default" in runtime_config.keys()
+    def test_deserialize_int(self): 
+        input = 'linewrap: 23, default_hour: 19'
+        runtime_config = deserialize_config_args(input)
+        assert runtime_config['linewrap'] == 23 
+        assert runtime_config['default_hour'] == 19
 
+    def test_deserialize_multiple_datatypes(self): 
+        input = 'linewrap: 23, encrypt: false, editor:"vi -c startinsert"'
+        cfg = deserialize_config_args(input) 
+        assert cfg['encrypt'] == False 
+        assert cfg['linewrap'] == 23 
+        assert cfg['editor'] == '"vi -c startinsert"'
 
 def test_editor_override():