jrnl/tests/data/journals/basic_folder/2020/09/should-be-ignored.txt at 7923e815f7560b5a11cf4c49008c2e10f907e39e - fz0x1/jrnl - Shivering Isles: cheeese....

fz0x1/jrnl

mirror of https://github.com/jrnl-org/jrnl.git synced 2025-05-10 16:48:31 +02:00

Micah Jerome Ellison 95836a7dd1

Only read text files that look like entries when opening folder journal (#1697 )

* Add text file that should be ignored to basic test folder journal. Makes tons of tests fail
* Add additional files that should be ignored by FolderJournal
* Ignore all files in folder journal except year/month/day.txt
* Completely remake get_files in FolderJournal:
- move get_files into FolderJournal class and add underscore prefix
- create iterables to get for year/month folders and day files
- make year/month/day file reading strict: only exact expected months and days out of all possible months and days
* Restore accidentally-deleted self.sort() line
* Use match instead of string comparison to be os-agnostic
* Explicitly declare static methods
* Filter with glob first for max performance
* Explicitly check for valid dates in FolderJournal and add unit test
* Remove unneeded jrnl import
* Clean up method comment and add type hints
* Add is_valid_date unit test
* Elucidate comment

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>

2023-04-29 15:49:41 -07:00

4 lines

No EOL

276 B

Text

Raw Blame History

 [2022-03-02 9:25:00 AM] This file should be ignored (month)
 This text file is in a folder journal's month directory ("2020/09"), but it's not in the file name format used by jrnl for folder journal entries, so it should be ignored.
 This file should not ever appear in a test.