fz0x1/pricehist
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix UNIX timestamp logic to avoid timezone issues for yahoo and coinmarketcap.

Browse source
This commit is contained in:
Chris Berkhout 2021-07-14 16:22:35 +02:00
parent ab0c0bdca7
commit d506b8502e
2 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/pricehist/sources/coinmarketcap.py
View file

@ -1,6 +1,6 @@
import dataclasses import dataclasses
import json import json
from datetime import datetime from datetime import datetime, timezone
from decimal import Decimal from decimal import Decimal
import requests import requests
@ -77,10 +77,19 @@ class CoinMarketCap(BaseSource):
params["convert"] = series.quote params["convert"] = series.quote
params["time_start"] = int( params["time_start"] = int(
int(datetime.strptime(series.start, "%Y-%m-%d").timestamp()) int(
datetime.strptime(series.start, "%Y-%m-%d")
.replace(tzinfo=timezone.utc)
.timestamp()
)
) )
params["time_end"] = ( params["time_end"] = (
int(datetime.strptime(series.end, "%Y-%m-%d").timestamp()) + 24 * 60 * 60 int(
datetime.strptime(series.end, "%Y-%m-%d")
.replace(tzinfo=timezone.utc)
.timestamp()
)
+ 24 * 60 * 60
) # round up to include the last day ) # round up to include the last day
response = self.log_curl(requests.get(url, params=params)) response = self.log_curl(requests.get(url, params=params))

14
src/pricehist/sources/yahoo.py
View file

@ -2,7 +2,7 @@ import csv
import dataclasses import dataclasses
import json import json
import logging import logging
from datetime import datetime from datetime import datetime, timezone
from decimal import Decimal from decimal import Decimal
import requests import requests
@ -102,8 +102,16 @@ class Yahoo(BaseSource):
) )
spark = json.loads(spark_response.content) spark = json.loads(spark_response.content)
start_ts = int(datetime.strptime(series.start, "%Y-%m-%d").timestamp()) start_ts = int(
end_ts = int(datetime.strptime(series.end, "%Y-%m-%d").timestamp()) + ( datetime.strptime(series.start, "%Y-%m-%d")
.replace(tzinfo=timezone.utc)
.timestamp()
)
end_ts = int(
datetime.strptime(series.end, "%Y-%m-%d")
.replace(tzinfo=timezone.utc)
.timestamp()
) + (
24 * 60 * 60 24 * 60 * 60
) # round up to include the last day ) # round up to include the last day